Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Athena / Presto support for some aspects of dbt utils #547

Closed
wants to merge 5 commits into from
Closed

Athena / Presto support for some aspects of dbt utils #547

wants to merge 5 commits into from

Conversation

SOVALINUX
Copy link

@SOVALINUX SOVALINUX commented Apr 14, 2022 •
edited

This is a:

  • bug fix PR with no breaking changes

Description & motivation

Currently I'm using dbt-unit-testing package to run unit tests and this package uses dbt-utils
My connector is Athena (Presto-based) and Athena/Presto doesn't support ilike operator - it has to be changed to more explicit regexp
Another issue is in not_null_proportion generic test due to type numeric what is not supported in Athena / Presto

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Athena
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@SOVALINUX SOVALINUX changed the title Athena / Presto support for get tables by pattern Athena / Presto support for some aspects of dbt utils Apr 15, 2022
@owenprough-sift
Copy link
Contributor

Some of these changes have existing implementations over in the athena-utils package.

@Tomme Tomme mentioned this pull request May 31, 2022
Closed
@joellabes
Copy link
Contributor

@SOVALINUX thanks for this! right now, this package is just for the core databases that dbt Labs supports; https://github.com/lalalilo/athena-utils is the place to go as @owenprough-sift says.

You might also like the discussion at #590

@joellabes joellabes closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SOVALINUX @owenprough-sift @joellabes